-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: Use only SQL single quotes for strings #13247
Conversation
Welcome at Mixxx! |
done |
Since this affects also the 2.4 branch I have changed the merge target. Can you rebase your fix to 2.4? |
New versions of sqlite no longer accept double quotes for string literals. On FreeBSD using sqlite 3.45.1 mixxx is unable to start, even with an empty database, because the migrations cannot be performed.
a7f8cc4
to
cc0148f
Compare
done, thanks! |
I have also prepared a patch for 2.3 (which I happen to have installed right now) |
Thank you, but 2.3 is no longer being developed. We will not be releasing any more 2.3 bugfix releases. |
LGTM! Thank you, for your first contribution to Mixxx! |
For the reference: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279284 is a downstream FreeBSD bug report, I have backported this to 2.3. there (an upgrade to 2.4.x is ongoing). |
New versions of sqlite no longer accept double
quotes for string literals.
On FreeBSD using sqlite 3.45.1 mixxx is unable
to start, even with an empty database, because
the migrations cannot be performed.