Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Use only SQL single quotes for strings #13247

Merged
merged 1 commit into from
May 25, 2024

Conversation

saper
Copy link
Contributor

@saper saper commented May 20, 2024

New versions of sqlite no longer accept double
quotes for string literals.

On FreeBSD using sqlite 3.45.1 mixxx is unable
to start, even with an empty database, because
the migrations cannot be performed.

@JoergAtGithub
Copy link
Member

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

@saper
Copy link
Contributor Author

saper commented May 21, 2024

done

@daschuer daschuer changed the base branch from main to 2.4 May 22, 2024 07:06
@daschuer
Copy link
Member

Since this affects also the 2.4 branch I have changed the merge target. Can you rebase your fix to 2.4?
I think it is
git rebase --onto=upstream/2.4 HEAD~1

New versions of sqlite no longer accept double
quotes for string literals.

On FreeBSD using sqlite 3.45.1 mixxx is unable
to start, even with an empty database, because
the migrations cannot be performed.
@saper saper force-pushed the sql-standard-quotes-schema branch from a7f8cc4 to cc0148f Compare May 22, 2024 07:34
@saper
Copy link
Contributor Author

saper commented May 22, 2024

done, thanks!

@saper
Copy link
Contributor Author

saper commented May 25, 2024

I have also prepared a patch for 2.3 (which I happen to have installed right now)
https://github.com/saper/mixxx/tree/sql-standard-quotes-schema-for-2.3 - shall I push a separate pull request for it?

@JoergAtGithub
Copy link
Member

Thank you, but 2.3 is no longer being developed. We will not be releasing any more 2.3 bugfix releases.

@JoergAtGithub
Copy link
Member

LGTM! Thank you, for your first contribution to Mixxx!

@JoergAtGithub JoergAtGithub merged commit c6c7d4e into mixxxdj:2.4 May 25, 2024
14 checks passed
@saper
Copy link
Contributor Author

saper commented May 25, 2024

For the reference: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279284 is a downstream FreeBSD bug report, I have backported this to 2.3. there (an upgrade to 2.4.x is ongoing).

@Swiftb0y
Copy link
Member

Swiftb0y commented May 25, 2024

@saper keep in mind that without ccc3e69 the autoDJ and Banshee Feature may be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants