Fix/gh12894 single quote sqlite string literals #13257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
force-pushed
the
fix/gh12894-single-quote-sqlite-string-literals
branch
3 times, most recently
from
b953954
to
643a3fa
Compare
|
I've found only those two so far, but I haven't reviewed everything yet. |
…ted are not disabled by default on SQlite >=3.41
Swiftb0y
force-pushed
the
fix/gh12894-single-quote-sqlite-string-literals
branch
from
643a3fa
to
ccc3e69
Compare
|
rebased. please review. |
|
LGTM! Thank you! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #13247 along with some manual follow up trying to replace these literals in our query-strings as well. Also based on 2.4 instead of
main(as #13247 currently is). I'd appreciate if someone could double check if I've missed any string.