Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32 Sampler fix #1736

Merged
merged 1 commit into from
Jul 5, 2018
Merged

32 Sampler fix #1736

merged 1 commit into from
Jul 5, 2018

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jul 2, 2018

@Pegasus-RPG
Copy link
Member

Is there a way to add a test for the problem this solves?

@daschuer
Copy link
Member Author

daschuer commented Jul 2, 2018

This was a trivial bug, I am not going to write a test for this.

@Pegasus-RPG
Copy link
Member

Okay. I'm not clear on how your changes will affect things, that's why I asked.

@daschuer
Copy link
Member Author

daschuer commented Jul 2, 2018

the issue was, that the output buffer was not cleared before the new samples where added.
So we hear garbage + the samplers.

@daschuer daschuer added this to the 2.1.2 milestone Jul 2, 2018
@uklotzde
Copy link
Contributor

uklotzde commented Jul 5, 2018

LGTM. I was able to reproduce the bug and verify that it has actually been fixed.

@daschuer
Copy link
Member Author

daschuer commented Jul 5, 2018

Thank you for review!

@daschuer daschuer merged commit f75f9b8 into mixxxdj:2.1 Jul 5, 2018
@daschuer daschuer deleted the lp1779559 branch September 26, 2021 17:35
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
major bug
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @Pegasus-RPG @uklotzde