Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new icon for Preferences > Key Detection #20

Merged
merged 2 commits into from
Jun 22, 2013

Conversation

esbrandt
Copy link
Contributor

The current icon (a single bar note) is replaced.
Why a new icon?

  • It can not be mistaken for with the existing iTunes icon.
  • it has a distinctive, but still familiar shape in the look of the existing icons.
  • The imagery of the icon is coherent with its message.

It consist of a clef and bold double barline. A clef is a musical symbol used to indicate the pitch of written notes, while a bold double bar line marks the end of a track. IMO it sums up exactly what key detection does - estimating the musical key of a track.

Note: I cant test the changes because the required rubberband library wont compile on OSX (not it macports nor homebrew).

…nt temp. icon. Add icon as vector to the icon template. Add a vertical spacer to dlgprefkeydlg.ui that prevents QGroupBoxes in there to grow infinitely.
@rryan
Copy link
Member

rryan commented Jun 22, 2013

Woo thanks!

rryan added a commit that referenced this pull request Jun 22, 2013
Add new icon for Preferences > Key Detection
@rryan rryan merged commit 40a87a6 into mixxxdj:features_key Jun 22, 2013
@esbrandt esbrandt deleted the features_key_icon branch November 16, 2013 06:42
@daschuer daschuer mentioned this pull request Dec 28, 2014
daschuer added a commit that referenced this pull request Jul 6, 2017
@daschuer daschuer mentioned this pull request Aug 13, 2017
19 tasks
@daschuer daschuer mentioned this pull request Jun 11, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants