Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Lock: make sure to reinit leader params after scratching ends #4005

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Sync Lock: make sure to reinit leader params after scratching ends #4005

merged 3 commits into from
Oct 25, 2021

Commits on Oct 23, 2021

  1. Sync Lock: make sure to reinit leader params after scratching ends 

    Fixes an issue where scratching the leader while another stopped deck was present would cause the leader to change pitch to resync.
    @ywwg
    ywwg committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    1fa010f View commit details
    Browse the repository at this point in the history

  2. Sync Lock: Have bpmcontrol override notifySeek

    @ywwg
    ywwg committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    b181060 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. Sync Lock: Make sure to update the leader beat distance after a seek 

    Because of half/double math, a phased seek might cause the Leader to be 0.5 beats off from where it used to be. Therefore after a seek, make sure to update the leader beat distance with the new value.
    @ywwg
    ywwg committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    3a2cabc View commit details
    Browse the repository at this point in the history