-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LateNight: use correct tooltip for key control toggle #4696
Conversation
Tested on Ubuntu and Windows 10: OK |
Please sqash the commits so that there's either one commit, or two (add tooltip string + add tooltip Id to skin(s)) |
I'm not allowed to sqash my commits here, or should I do this in my own fork? |
The squashing I referred to would happen in your local git repo. |
you'd do a rebase -i on your machine and then a git push --force. Also a note for our reviewers, we do have the Squash And Merge feature enabled for github. We can just use that instead of making contributors squash everything manually |
Thank you very much. |
I did a commit with command line. I did not find an example for this which I understand. |
It is the commit before your first commit.
Or
You need to put an |
f1f2700
to
1b2e86d
Compare
1b2e86d
to
153a8e7
Compare
That helped me, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you very much.
At skin settings wrong tooltip ID was used at Key Control toggle.
As well the corresponding ID at file tooltips.cpp was missing.