Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LateNight: use correct tooltip for key control toggle #4696

Merged
merged 1 commit into from
Mar 16, 2022
+8 −4
Merged

LateNight: use correct tooltip for key control toggle #4696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion res/skins/LateNight/helpers/skin_settings_compact_deck.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Description:

<!-- Key Control -->
<Template src="skin:/helpers/skin_settings_button_2state.xml">
<SetVariable name="TooltipId">rate_toggle</SetVariable>
<SetVariable name="TooltipId">show_key_controls</SetVariable>
<SetVariable name="Text">Key Controls</SetVariable>
<SetVariable name="Setting">[Skin],show_key_controls_compact</SetVariable>
</Template>
Expand Down
2 changes: 1 addition & 1 deletion res/skins/LateNight/helpers/skin_settings_full_deck.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Description:

<!-- Key Control -->
<Template src="skin:/helpers/skin_settings_button_2state.xml">
<SetVariable name="TooltipId">rate_toggle</SetVariable>
<SetVariable name="TooltipId">show_key_controls</SetVariable>
<SetVariable name="Text">Key Controls</SetVariable>
<SetVariable name="Setting">[Skin],show_key_controls</SetVariable>
</Template>
Expand Down
8 changes: 6 additions & 2 deletions src/skin/legacy/tooltips.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,11 +444,15 @@ void Tooltips::addStandardTooltips() {
<< tr("Toggling keylock during playback may result in a momentary audio glitch.");

add("hotcue_toggle")
<<tr("Changes the number of hotcue buttons displayed in the deck");
<< tr("Changes the number of hotcue buttons displayed in the deck");

// Show Rate Control
add("rate_toggle")
<<tr("Toggle visibility of Rate Control");
<< tr("Toggle visibility of Rate Control");

// Show Key Controls
add("show_key_controls")
<< tr("Toggle visibility of Key Controls");

// Used in cue/hotcue/loop tooltips below.
QString quantizeSnap = tr("If quantize is enabled, snaps to the nearest beat.");
Expand Down