plugins/news: Add support for multiple post authors #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can specify multiple post authors (comma separated), e.g.:
title: Multiple Authors Demo
author: Be., Pegasus, Albert, Holzhaus
date: 2020-06-20 12:00:00
ywwg
added a commit
to ywwg/website
that referenced
this pull request
Jun 20, 2020
Depends on PR mixxxdj#111
Swiftb0y
reviewed
Jun 20, 2020
| (<a href="https://github.com/{{ post.author_github }}">@{{ post.author_github }}</a>) | ||
| {% endif %} | ||
| </span> | ||
| {% if author.url %}<a href="{{ author.url }}">{{ author.name }}</a>{% else %}{{ author.name }}{% endif %}{% if author.github %} (<a href="https://github.com/{{ author.github }}">@{{ author.github }}</a>){% endif %}</span> |
There was a problem hiding this comment.
Is there a reason why this is a single line?
There was a problem hiding this comment.
Yes, because otherwise it will insert newlines into the HTML source, which creates a space before the comma.
| <span class="author">{% if author.url %}<a href="{{ author.url }}">{{ author.name }}</a>{% else %}{{ author.name }}{% endif %}{% if author.github %} (<a href="https://github.com/{{ author.github }}">@{{ author.github }}</a>){% endif %}</span>, | ||
| {% endfor %} | ||
| {% for author in authors|slice:"-2:-1" %} | ||
| <span class="author">{% if author.url %}<a href="{{ author.url }}">{{ author.name }}</a>{% else %}{{ author.name }}{% endif %}{% if author.github %} (<a href="https://github.com/{{ author.github }}">@{{ author.github }}</a>){% endif %}</span> and |
There was a problem hiding this comment.
not very familiar with cactus, but is there any way to reduce the duplication using a macro or smth?
There was a problem hiding this comment.
Not really. We could put it into a separate template and include that here, but that also would also lead to superfluous newlines
Swiftb0y
approved these changes
Jun 21, 2020
|
@ywwg we forgot to merge this prior to the BLM post. |
|
Now there is a merge conflict. |
…tiple-news-authors
Resolved. |
|
oh yeah we need to get this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can specify multiple post authors (comma separated), e.g.:
Useful for #110.