Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccurate hysen temperature #720

Closed
wants to merge 2 commits into from
Closed

Fix inaccurate hysen temperature #720

wants to merge 2 commits into from

Conversation

fustom
Copy link
Contributor

@fustom fustom commented Oct 5, 2022

Context

Hysen heating thermostat returned inaccurate temperature.

Proposed change

Hysen payload[17] first half contains the the missing bits.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

Copy link

@rjulius23 rjulius23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjulius23
Copy link

@felipediel is it possible to get this to the latest release ?

@felipediel
Copy link
Collaborator

It may take a while for the next release, I'm swamped with work and no free time to work on this integration.

This code would also need a clean up and rebase, as it is incompatible with the current version of the dev branch. If the author doesn't know how to do it, I can help as soon as I have time.

Thanks for the contribution anyway, this is certainly something we want to add.

@rjulius23
Copy link

Can this be released ?

@rjulius23
Copy link

@felipediel it looks fine to me, does this need any further cleaning up ? How can I help ?

@felipediel
Copy link
Collaborator

Don't worry, I will merge it before the next release, I just don't have time for the whole release process right now, I will be back when I do

@rjulius23
Copy link

Can I help with the release process ? Is there a guide ?

@fustom
Copy link
Contributor Author

fustom commented Oct 5, 2023

Happy 1st year anniversary.

@rjulius23
Copy link

How can we push this to release ?

@felipediel
Copy link
Collaborator

Sorry, I am on a rush, I cannot change focus right now. To create a new release we need to analyze all breaking changes we've made since the last version and submit a PR to Home Assistant in order to keep it up to date.

I feel that I'm not giving enough attention to this project, but I just can't, my job is demanding everything I have. Maybe we need more people to help with updates, if anyone is interested ping mjg.

*Be aware that it takes some spare time and responsibility, this project has thousands of active users and if something breaks it needs to be fixed immediately.

@rjulius23
Copy link

Hey @mjg59,

I can have some spare time to help out with some tasks. Can you link me a guid or tasks that I can do to help ?

cheers,
Gyula

@sancyx
Copy link

sancyx commented Jan 23, 2024

It seems to me that this PR addresses the same problem as this: #720.
Actually it seems a bit more accurate. I'm newbie in HASS and actually using Computherm E series thermostats with https://github.com/algirdasc/hass-floureon which is based on broadIink module. So not sure how can I help but would also love this to be fixed.

@felipediel
Copy link
Collaborator

Thank you @fustom! I believe that #772 has fixed the problem. If not, please reopen this PR.

@felipediel felipediel closed this Apr 9, 2024
@fustom
Copy link
Contributor Author

fustom commented Apr 10, 2024

Yeah #772 also works. I don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants