Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermostat: get the 1st decimal place #772

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Thermostat: get the 1st decimal place #772

merged 1 commit into from
Apr 9, 2024

Conversation

irsl
Copy link
Contributor

@irsl irsl commented Oct 31, 2023

Context

The Broadlink Hysen thermostats do support 1 decimal precision, but this library did not extract that information. This PR provides access to the additional bit of information.

Proposed change

I decompiled a relevant Android app to learn how it extracts temperature values with 1 decimal place precision. The relevant part of the code can be found here: https://pastebin.com/EYHBJ5sn
I ported the logic to this codebase and the numbers are now showing up fine in HA.

I tested this with Computherm E400RF and Computherm E280 (a product by a Hungarian vendor).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • [] Documentation added/updated.

@sancyx
Copy link

sancyx commented Jan 23, 2024

Would be nice to have this released. Are you using this component directly in HASS or via https://github.com/algirdasc/hass-floureon?

@felipediel felipediel merged commit d7ed985 into mjg59:dev Apr 9, 2024
@felipediel
Copy link
Collaborator

Good job @irsl! Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants