Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Sheets and Excel temp CSV filename needs to be unique during secondary tasks #557

Closed
mjordan opened this issue Feb 15, 2023 · 2 comments
Closed

Google Sheets and Excel temp CSV filename needs to be unique during secondary tasks #557

mjordan opened this issue Feb 15, 2023 · 2 comments
Assignees
@mjordan
Labels
bug Something isn't working Input data validation CSV and file input data validation / reduction of potential for data error

Comments

@mjordan
Copy link
Owner

mjordan commented Feb 15, 2023

When using a secondary task and a Google Sheet as input for both the primary and secondary tasks, if google_sheets_csv_filename is not set or not unique per task, secondary tasks stomp on the primary task's temp CSV filename. This can be avoided by configuring a unique value for the google_sheets_csv_filename setting in all config files, but Workbench should warn the user if the temporary CSV filename is not unique, both during --check and outside of --check.
@mjordan mjordan added bug Something isn't working Input data validation CSV and file input data validation / reduction of potential for data error labels Feb 15, 2023
@mjordan mjordan self-assigned this Feb 15, 2023
mjordan added a commit that referenced this issue Feb 20, 2023
@mjordan
WIP on #557.
d5b5276
mjordan added a commit that referenced this issue Feb 20, 2023
@mjordan
WIP on #557.
194a3fb
@mjordan
Copy link
Owner Author

mjordan commented Feb 20, 2023

Same applies to using an Excel file.

mjordan added a commit that referenced this issue Feb 21, 2023
@mjordan
WIP on #557.
e0e655e
mjordan added a commit that referenced this issue Feb 21, 2023
@mjordan
WIP on #557 - Added Excel test data.
b949aa2
mjordan added a commit that referenced this issue Feb 21, 2023
@mjordan
WIP on #557.
9c6b9e9
mjordan added a commit that referenced this issue Feb 22, 2023
@mjordan
WIP on #557.
149adc0
mjordan added a commit that referenced this issue Feb 22, 2023
@mjordan
WIP on #557.
ba87b2c
@mjordan
Copy link
Owner Author

mjordan commented Feb 22, 2023

Resolved with ba87b2c. Integration tests included.

@mjordan mjordan closed this as completed Feb 22, 2023
@mjordan mjordan changed the title Google Sheets temp CSV filename needs to be unique during secondary tasks Google Sheets and Excel temp CSV filename needs to be unique during secondary tasks Feb 22, 2023
@mjordan mjordan mentioned this issue Mar 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjordan mjordan

Labels
bug Something isn't working Input data validation CSV and file input data validation / reduction of potential for data error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjordan