Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert secondary tasks data file to an SQLite database #574

Closed
mjordan opened this issue Mar 4, 2023 · 2 comments
Closed

Convert secondary tasks data file to an SQLite database #574

mjordan opened this issue Mar 4, 2023 · 2 comments
Assignees
@mjordan
Labels
code cleanup Clean up code, including code-level comments

Comments

@mjordan
Copy link
Owner

mjordan commented Mar 4, 2023

Currently it's a TSV file. Making it an SQLite db is probably a more robust approach.
@mjordan mjordan added the code cleanup Clean up code, including code-level comments label Mar 4, 2023
@mjordan mjordan self-assigned this Mar 4, 2023
@mjordan
Copy link
Owner Author

mjordan commented Mar 4, 2023

Now that since the resolution of #557 secondary task config file paths are now stored in the ISLANDORA_WORKBENCH_SECONDARY_TASKS environment variable.

mjordan added a commit that referenced this issue Mar 15, 2023
@mjordan
WIP on #574: added sqlite_manager function and unit tests.
4e217eb
@mjordan
Copy link
Owner Author

mjordan commented Mar 15, 2023 •
edited
Loading

sqlite_manager() added; replacing secondary tasks data with a db remains to be complete.

Added new config setting sqlite_db_filename with default value "workbench_temp_data.db". This will replace the secondary_tasks_data_file config setting.

@mjordan mjordan mentioned this issue Mar 17, 2023
Closed
mjordan added a commit that referenced this issue Mar 21, 2023
@mjordan
WIP on #574.
2d2b8f1
mjordan added a commit that referenced this issue Mar 21, 2023
@mjordan
WIP on #574.
f7a0ffd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjordan mjordan

Labels
code cleanup Clean up code, including code-level comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjordan