Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI/CD to build default Fondant base image #782

Closed
Tracked by #558
RobbeSneyders opened this issue Jan 15, 2024 · 0 comments · Fixed by #801
Closed
Tracked by #558

Add CI/CD to build default Fondant base image #782

RobbeSneyders opened this issue Jan 15, 2024 · 0 comments · Fixed by #801
Assignees
@mrchtr
Labels
CI/CD Related to CI/CD of the repository

Comments

@RobbeSneyders
Copy link
Member

RobbeSneyders commented Jan 15, 2024 •
edited
Loading

Lightweight Python components need a default base image to run on, which we should provide. Probably for all Python versions we support. I would build them everytime we build our reusable images.

We should also make sure the base image with the appropriate Fondant version installed is used automatically (comment).
@RobbeSneyders RobbeSneyders mentioned this issue Jan 15, 2024
Closed
@RobbeSneyders RobbeSneyders added the CI/CD Related to CI/CD of the repository label Jan 16, 2024
@RobbeSneyders RobbeSneyders mentioned this issue Jan 17, 2024
Merged
@mrchtr mrchtr self-assigned this Jan 18, 2024
@mrchtr mrchtr mentioned this issue Jan 19, 2024
Merged
mrchtr added a commit that referenced this issue Jan 25, 2024
@mrchtr
Add fondant base image (#801)
7356b6a 
The PR contains the docker file for the base image and adjusts the code
to use the base image for the python components.

Base images follow the naming schema: `fndnt/fondant:fondant_version-py_version`, for example, `fndnt/fondant:0.9.0-py3.10`.


Fix #782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrchtr mrchtr

Labels
CI/CD Related to CI/CD of the repository
Projects
Fondant development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fondant base image ml6team/fondant
2 participants
@mrchtr @RobbeSneyders