Add support to run lightweight python components in docker runner #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
requested review from
mrchtr,
GeorgesLorre and
PhilippeMoussalli
RobbeSneyders
commented
Jan 16, 2024
| @@ -44,5 +85,4 @@ def transform(self, dataframe: pd.DataFrame) -> pd.DataFrame: | |||
| ref=AddN, | |||
| produces={"x": pa.int32(), "y": pa.int32()}, | |||
| consumes={"x": pa.int32(), "y": pa.int32()}, | |||
| arguments={"n": 1}, | |||
There was a problem hiding this comment.
We still need to integrate #763 to support arguments.
| @@ -45,6 +47,37 @@ def log_unused_configurations(self, **kwargs): | |||
| f" for runner `{self.__class__.__name__}`.", | |||
| ) | |||
|
|
|||
| @staticmethod | |||
| def _build_entrypoint(image: Image) -> t.List[str]: | |||
There was a problem hiding this comment.
Don't really know how to test this without either replicating the logic or comparing against an unreadable string, so for now this is only tested via the integration test.
Open for ideas.
There was a problem hiding this comment.
IMO comparing to a hard to read string is fine
There was a problem hiding this comment.
Not sure how valuable it is though, because I would just copy paste the generated string at this moment. It would be the old compiler tests all over again :)
mrchtr
reviewed
Jan 17, 2024
mrchtr
approved these changes
Jan 17, 2024
GeorgesLorre
approved these changes
Jan 17, 2024
| @@ -45,6 +47,37 @@ def log_unused_configurations(self, **kwargs): | |||
| f" for runner `{self.__class__.__name__}`.", | |||
| ) | |||
|
|
|||
| @staticmethod | |||
| def _build_entrypoint(image: Image) -> t.List[str]: | |||
There was a problem hiding this comment.
IMO comparing to a hard to read string is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #753