Add node pool label #327
Merged
Add node pool label #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @shayorshay ! :)
This will come in handy for different clouds. Left one small comments to handle edge cases and maybe add a test for it.
| @@ -80,6 +82,7 @@ def __init__( | |||
| self.arguments.setdefault("component_spec", self.component_spec.specification) | |||
|
|
|||
| self.number_of_gpus = number_of_gpus | |||
| self.node_pool_label = node_pool_label | |||
| self.node_pool_name = node_pool_name | |||
| self.p_volumes = p_volumes | |||
| self.ephemeral_storage_size = ephemeral_storage_size | |||
There was a problem hiding this comment.
Since both the label and the name depend on each other. Can you raise an error if one of them is not provided?
from fondant.exceptions import InvalidPipelineDefinition
if bool(node_pool_label) != bool(node_pool_name):
raise InvalidPipelineDefinition("Both 'node_pool_label' and 'node_pool_name' must be defined or both must be None.")And can you also test that a valid error is returned by adding two example to test_component_op, one where the name is defined and the label is not and the other way around:
fondant/tests/test_pipeline.py
Line 35 in 5b123bf
There was a problem hiding this comment.
I added the error checking and test. Could you please check? @PhilippeMoussalli
PhilippeMoussalli
approved these changes
Aug 1, 2023
RobbeSneyders
added a commit
that referenced
this pull request
Aug 10, 2023
Our current example pipelines don't work anymore out of the box since #327 requires `node_pool_label` and `node_pool_name` to either both be set, or neither. This PR removes the `node_pool_name` since it is very specific to our own kfp cluster anyway.
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
This PR adds a configurable node pool label in the pipeline specification. This is needed because the default label name differs per cloud provider.
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Our current example pipelines don't work anymore out of the box since #327 requires `node_pool_label` and `node_pool_name` to either both be set, or neither. This PR removes the `node_pool_name` since it is very specific to our own kfp cluster anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable node pool label in the pipeline specification. This is needed because the default label name differs per cloud provider.