Remove node_pool_name arguments in examples #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Our current example pipelines don't work anymore out of the box since #327 requires `node_pool_label` and `node_pool_name` to either both be set, or neither. This PR removes the `node_pool_name` since it is very specific to our own kfp cluster anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current example pipelines don't work anymore out of the box since #327 requires
node_pool_labelandnode_pool_nameto either both be set, or neither.This PR removes the
node_pool_namesince it is very specific to our own kfp cluster anyway.