Revert fsspec changes #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are there downsides of keeping it in case another bug appears later on? I also think it makes it more explicit that we're creating a directory if it doesn't exist |
|
Agree with @PhilippeMoussalli, but I do think we should remove it for reading. Doesn't really make sense to create the directories there. |
|
I've updated the PR. Now the |
PhilippeMoussalli
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in fsspec, we added
auto_mkdir=Trueto the fsspec calls. This is no longer necessary. This PR reverts the changes and avoids using the version with the bug.