Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fsspec changes #523

Merged
merged 4 commits into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ importlib-resources = { version = ">= 1.3", python = "<3.9" }
jsonschema = ">= 4.18"
pyarrow = ">= 11.0.0"

fsspec = { version = ">= 2023.4.0", optional = true}
fsspec = { version = ">= 2023.4.0, !=2023.9.1", optional = true}
mrchtr marked this conversation as resolved.
Show resolved Hide resolved
gcsfs = { version = ">= 2023.4.0", optional = true }
s3fs = { version = ">= 2023.4.0", optional = true }
adlfs = { version = ">= 2023.4.0", optional = true }
Expand Down
1 change: 0 additions & 1 deletion src/fondant/executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ def _get_cached_manifest(self) -> t.Union[Manifest, None]:
manifest_reference_path,
mode="rt",
encoding="utf-8",
auto_mkdir=True,
) as file_:
cached_manifest_path = file_.read()
manifest = Manifest.from_file(cached_manifest_path)
Expand Down
2 changes: 1 addition & 1 deletion src/fondant/manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def create(
@classmethod
def from_file(cls, path: t.Union[str, Path]) -> "Manifest":
"""Load the manifest from the file specified by the provided path."""
with fs_open(path, encoding="utf-8", auto_mkdir=True) as file_:
with fs_open(path, encoding="utf-8") as file_:
specification = json.load(file_)
return cls(specification)

Expand Down
Loading