Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master into 2.1 #1187

Closed
wants to merge 5 commits into from
Closed

Merge master into 2.1 #1187

wants to merge 5 commits into from

Conversation

tjablin
Copy link
Contributor

@tjablin tjablin commented Jul 25, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 25, 2022 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@tjablin tjablin requested a review from rnaidu02 July 25, 2022 17:53
nv-jinhosuh and others added 2 commits July 25, 2022 15:45
@nv-jinhosuh @rnaidu02
[Loadgen for LON] making non-const function for sut->Name() call (#1184)
ef663f8 
* [Loadgen for LON] making non-const function for sut->Name() call

sut->Name() call requiires dynamic behavior through QDL in LON.

* Removing const from SUT Name()

* Removing const from Name() - missed ones

Co-authored-by: rameshchukka <rnaidu02@yahoo.com>
@arjunsuresh @rnaidu02
Update run_local.sh (#1181)
7c3c697 
Using python3 is easier here as python2 is not used anymore and python command gives error on macOS

Co-authored-by: rameshchukka <rnaidu02@yahoo.com>
@lgtm-com
Copy link

lgtm-com bot commented Jul 25, 2022

This pull request fixes 12 alerts when merging 7c3c697 into 67eb6a0 - view on LGTM.com

fixed alerts:

  • 9 for Unused import
  • 2 for Duplicate key in dict literal
  • 1 for Unused local variable

@pgmpablo157321 pgmpablo157321 mentioned this pull request Jul 26, 2022
Merged
@rnaidu02
Copy link
Contributor

#1191 is created to address the issues with merging. Closing this PR.

@rnaidu02 rnaidu02 closed this Jul 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pgmpablo157321 pgmpablo157321 pgmpablo157321 approved these changes

@rnaidu02 rnaidu02 rnaidu02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tjablin @rnaidu02 @pgmpablo157321 @nvitramble @morphine00 @georgelyuan @nv-jinhosuh @arjunsuresh