Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing obsolete audit directory #1188

Merged
merged 1 commit into from
Jul 25, 2022
Merged

removing obsolete audit directory #1188

merged 1 commit into from
Jul 25, 2022

Conversation

georgelyuan
Copy link
Contributor

to avoid confusion

@github-actions
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@lgtm-com
Copy link

lgtm-com bot commented Jul 25, 2022

This pull request fixes 12 alerts when merging 74eb5ac into fc02e9b - view on LGTM.com

fixed alerts:

  • 9 for Unused import
  • 2 for Duplicate key in dict literal
  • 1 for Unused local variable

@georgelyuan georgelyuan requested a review from tjablin July 25, 2022 18:41
pgmpablo157321
pgmpablo157321 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@pgmpablo157321 pgmpablo157321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let’s make sure we remove these files in r2.1 as well. We could:

  1. Make another PR to r2.1
  2. Make sure this is merged before Merge master into 2.1 #1187 so that we merge master into r2.1 afterwards.

@rnaidu02 rnaidu02 merged commit ef8e58e into mlcommons:master Jul 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pgmpablo157321 pgmpablo157321 pgmpablo157321 approved these changes

@tjablin tjablin Awaiting requested review from tjablin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgelyuan @pgmpablo157321 @rnaidu02