Merge pull request #293 from mlibrary/2024-05-01-updates

Updating `eslint` and rebuilding the setup.

.github/PULL_REQUEST_TEMPLATE/dependency_updates_template.md

@@ -3,13 +3,10 @@ Monthly dependency update to help maintain Account.
 
 ## NPM
 These dependencies have been updated to their latest versions:
+- `@eslint/js`
 - `esbuild`
 - `eslint`
-- `eslint-config-standard`
-- `eslint-plugin-import`
-- `eslint-plugin-node`
-- `eslint-plugin-promise`
-- `eslint-webpack-plugin`
+- `globals`
 - `sass`
 
 ## Workflows

eslint.config.mjs

@@ -0,0 +1,21 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+
+export default [
+ pluginJs.configs.recommended,
+ {
+ languageOptions: {
+ globals: globals.browser
+ }
+ },
+ {
+ rules: {
+ "arrow-body-style": ["error", "always"], // Requires {} in arrow function body
+ "arrow-parens": ["error", "always"], // Requires () around arrow function arguments
+ "brace-style": ["error", "1tbs"], // Requires one true brace style
+ "no-empty-function": "error", // Require an empty function to at least have a comment explaining why
+ "no-var": "error", // Discourages using `var` and recommends using `let` or `const` instead
+ "semi": ["error", "always"] // Requires a semicolon wherever necessary
+ }
+ }
+];

js/index.js

@@ -39,7 +39,7 @@
  }
  event.target.innerHTML = 'Error!';
  throw new Error(`Could not cancel request id ${requestID}.`);
- }).then((data) => {
+ }).then(() => {
  event.target.innerHTML = 'Canceled!';
  event.target.disabled = true;
  }).catch((error) => {
@@ -120,7 +120,7 @@
  }
  });
  });
- window.addEventListener('resize', (event) => {
+ window.addEventListener('resize', () => {
  if (
  (window.innerWidth <= breakpoint && !getAriaExpanded) ||
  (window.innerWidth > breakpoint && getAriaExpanded)

js/settings.js

@@ -38,7 +38,7 @@ let previousFocus = false;
 document.addEventListener('keydown', (event) => {
  previousFocus = event.shiftKey && event.key === 'Tab';
 });
-document.addEventListener('focusin', (event) => {
+document.addEventListener('focusin', () => {
  if (getModal.style.display !== 'none' && !getModal.querySelectorAll(':focus').length) {
  previousFocus ? deleteHistoryButton.focus() : closeButton.focus();
  }