Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating eslint and rebuilding the setup. #293

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

erinesullivan
Copy link
Collaborator

Overview

dependabot has made its first update, which exposed eslint-config-standard not being up to date in over a year. It is not compatible with the latest version of eslint. Turns out that initializing eslint has changed. This pull request uninstalls all eslint-related dependencies and follows the new setup, which added these dependencies:

  • @eslint/js
  • globals

These dependencies have been removed:

  • eslint-config-standard
  • eslint-plugin-import
  • eslint-plugin-node
  • eslint-plugin-promise
  • eslint-webpack-plugin

Testing

  • Run the tests to make sure they pass (docker-compose run --rm web bundle exec rspec).
    • Break the new/updated unit tests to make sure they're working properly.
  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Run npm run eslint and see if files pass. Make some changes to files that would throw an error and run again.

@erinesullivan erinesullivan added the dependencies Changes to packages or gems. label May 1, 2024
@erinesullivan erinesullivan self-assigned this May 1, 2024
@erinesullivan erinesullivan merged commit f63ad47 into main May 1, 2024
1 check passed
@erinesullivan erinesullivan deleted the 2024-05-01-updates branch May 1, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to packages or gems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant