Merge pull request #409 from mlpack/feature/arma_14.2.0_change

Armadillo 14.2.0 deprecation changes to (index) .min() and .max()

HISTORY.md

@@ -6,6 +6,9 @@
  * Bump minimum Armadillo version to 10.8
    ([#404](https://github.com/mlpack/ensmallen/pull/404)).
 
+ * For Armadillo 14.2.0 switch to `.index_min()` and `.index_max()`
+   ([#409](https://github.com/mlpack/ensmallen/pull/409).
+
 ### ensmallen 2.21.1: "Bent Antenna"
 ###### 2024-02-15
  * Fix numerical precision issues for small-gradient L-BFGS scaling factor

include/ensmallen_bits/fw/atoms.hpp

@@ -96,8 +96,7 @@ class Atoms
       // Find possible atom to be deleted.
       arma::vec gap = sqTerm -
           currentCoeffs % trans(gradient.t() * currentAtoms);
-      arma::uword ind;
-      gap.min(ind);
+      arma::uword ind = gap.index_min();
 
       // Try deleting the atom.
       arma::mat newAtoms(currentAtoms.n_rows, currentAtoms.n_cols - 1);

include/ensmallen_bits/fw/constr_lpball.hpp

@@ -118,8 +118,8 @@ class ConstrLpBallSolver
       else
         s = arma::abs(v);
 
-      arma::uword k = 0;
-      s.max(k);  // k is the linear index of the largest element.
+      // k is the linear index of the largest element.
+      arma::uword k = s.index_max();
       s.zeros();
       // Take the sign of v(k).
       s(k) = -((0.0 < v(k)) - (v(k) < 0.0));