Armadillo 14.2.0 deprecation changes to (index) .min() and .max() #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an Armadillo 14.2.0 change that creates a fair amount of compilation noise for mlpack right now. There are likely more changes to be made but this will check the mechanics.
rcurtin
approved these changes
Nov 19, 2024
|
How is this? Am I hitting the desired format? Maybe should mention modified HISTORY.md
@@ -6,6 +6,9 @@
* Bump minimum Armadillo version to 10.8
([#404](https://github.com/mlpack/ensmallen/pull/404)).
+ * Accommodate Armadillo 14.2.0 deprecations
+ ([#409](https://github.com/mlpack/ensmallen/pull/409).
+
### ensmallen 2.21.1: "Bent Antenna"
###### 2024-02-15
* Fix numerical precision issues for small-gradient L-BFGS scaling factor(Now done with slightly different text in b19f75e.) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building
mlpackunder R using (Rcpp)Armadillo 14.2.0-1 leads to deprecation warnings which e.g. CRAN nags about. The warnings start with the index minimum call inatoms.hpp; the change addresses andensmallen(or ratherRcppEnsmallen) still tests fine with it. The second change is only other case I found with a quick search, there may be more.