Prepare plan before compacting in MarkCompact #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we trace the same set of objects in the two traces.
qinsoon
added
the
PR-testing
tianleq
reviewed
Jan 21, 2022
| @@ -153,7 +153,6 @@ impl<VM: VMBinding> LargeObjectSpace<VM> { | |||
|
|
|||
| pub fn prepare(&mut self, full_heap: bool) { | |||
| if full_heap { | |||
| debug_assert!(self.treadmill.from_space_empty()); | |||
| self.mark_state = MARK_BIT - self.mark_state; | |||
| } | |||
| self.treadmill.flip(full_heap); | |||
There was a problem hiding this comment.
I feel that flip the from/to space will leak dead objects. After the first trace, live objects have been copied to the to space and what left in from space are dead objects. Now after the flip, the from space will become the to space, and those dead objects will be treated as live. At this stage, sweep has not been executed yet.
There was a problem hiding this comment.
You are right. I will work on this.
There was a problem hiding this comment.
#944 fixes the issues by calling release before preparing it again.
|
#944 fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #520.
This PR
max_non_los_default_alloc_bytesfor mark compactprepare()call for mark compact before the compact transitive closure