Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MarkCompact LOS support 2nd transitive closure #944

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

wenyuzhao
Copy link
Member

@wenyuzhao wenyuzhao commented Sep 5, 2023

#939 makes MarkCompact GC allocate large objects into LOS, instead of mark-compacting everything. However, LOS should be released and re-prepared properly, otherwise marking in the pointer forwarding trace will not behave correctly.

This should fix the OpenJDK binding test failures.

@wenyuzhao wenyuzhao added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Sep 5, 2023
qinsoon
qinsoon previously approved these changes Sep 5, 2023
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@qinsoon qinsoon dismissed their stale review September 5, 2023 22:25

More discussion is needed.

@qinsoon
Copy link
Member

qinsoon commented Sep 5, 2023

I just realized I attempted a similar approach on this before: #527. @tianleq left a comment here #527 (comment), suggesting there could be a memory leak. That comment is probably still relevant for this PR.

Given that the current tests are broken, getting the tests running again would be the priority. If we do not have a better solution, I suggest we merge this PR once we understand the consequence (e.g. we would have memory leak for LOS in mark compact).

@wenyuzhao
Copy link
Member Author

I just realized I attempted a similar approach on this before: #527. @tianleq left a comment here #527 (comment), suggesting there could be a memory leak. That comment is probably still relevant for this PR.

Given that the current tests are broken, getting the tests running again would be the priority. If we do not have a better solution, I suggest we merge this PR once we understand the consequence (e.g. we would have memory leak for LOS in mark compact).

After discussing with @tianleq , releasing once before the second prepare call should have no memory leak issue. All dead objects are cleared before the second prepare.

Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Sep 6, 2023
Merged via the queue into mmtk:master with commit 42991c2 Sep 6, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants