Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement transparent hugepage support #905

Merged
merged 11 commits into from
Aug 17, 2023
Merged

Conversation

caizixian
Copy link
Member

No description provided.

@caizixian caizixian requested review from qinsoon and wenyuzhao August 16, 2023 09:36
@caizixian caizixian added PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) PR-benchmarking and removed PR-benchmarking labels Aug 16, 2023
@mmtkgc-bot
Copy link

mmtkgc-bot commented Aug 16, 2023

Running benchmarks for JikesRVM...

@mmtkgc-bot
Copy link

mmtkgc-bot commented Aug 16, 2023

Running benchmarks for OpenJDK...

Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It seems the macro crate code got reformatted (accidentally?). That is not related with the core purpose of the PR. Generally it is preferrable to separate PRs for unrelated changes.

@qinsoon
Copy link
Member

qinsoon commented Aug 17, 2023

It seems the CI checks got stuck. Maybe try push a new commit.

@caizixian caizixian removed the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Aug 17, 2023
@caizixian
Copy link
Member Author

caizixian commented Aug 17, 2023

LGTM.

It seems the macro crate code got reformatted (accidentally?). That is not related with the core purpose of the PR. Generally it is preferrable to separate PRs for unrelated changes.

Yeah, I think cargo fmt reformatted the entire repo (probably because I have my workspace configured as a cargo workspace). I reverted these changes.

@caizixian caizixian linked an issue Aug 17, 2023 that may be closed by this pull request
@caizixian caizixian merged commit 4873b4a into mmtk:master Aug 17, 2023
@caizixian caizixian deleted the hugepages branch August 17, 2023 04:49
qinsoon added a commit that referenced this pull request Aug 18, 2023
This commit was originally backed out of #905. Add clippy check and
cargo fmt check for auxiliary crates (`macros` and `dummyvm`).

---------

Co-authored-by: Yi Lin <qinsoon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants