Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply style check on auxiliary crates (macros and dummyvm) #913

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Apply style check on auxiliary crates (macros and dummyvm) #913

merged 5 commits into from
Aug 18, 2023

Conversation

caizixian
Copy link
Member

@caizixian caizixian commented Aug 17, 2023 •
edited by qinsoon
Loading

This commit was originally backed out of #905. Add clippy check and cargo fmt check for auxiliary crates (macros and dummyvm).

@caizixian caizixian requested a review from qinsoon August 17, 2023 13:16
@qinsoon qinsoon changed the title Apply cargo fmt on macros Apply style check on auxiliary crates (macros and dummyvm) Aug 18, 2023
qinsoon
qinsoon approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit c9ea320 into mmtk:master Aug 18, 2023
@caizixian caizixian deleted the macros-fmt branch August 22, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon qinsoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caizixian @qinsoon