Use MMTk builder API #118
Merged
Use MMTk builder API #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wks
approved these changes
Jul 19, 2022
mmtk/src/api.rs
Outdated
| debug_assert!(731 == JikesRVM::mm_entrypoint_test(21, 34, 9, 8)); | ||
|
|
||
| // set heap size | ||
| memory_manager::process(&BUILDER, "heap_size", heap_size.to_string().as_str()); |
There was a problem hiding this comment.
If mmtk-core can expose &mut Options directly, we won't need to convert heap_size into a string.
qinsoon
added a commit
to mmtk/mmtk-core
that referenced
this pull request
Jul 20, 2022
This PR adds `MMTKBuilder`, and changes APIs around initializing MMTk. The change allows all the options to be set from command line, including heap size, plan, GC threads, etc. This PR closes #623. This PR is also an initial step for #541. For #541, we may need further changes. * Add `MMTKBuilder` * `gc_init()` now takes a reference to `MMTKBuilder` as its argument, and returns a boxed pointer to the new MMTk instance created. * `gc_init()` is renamed to `mmtk_init()`. * `gc_init()` no longer requires a `heap_size` argument. `heap_size` now is an option. * allow options for `plan`, `threads`, `vm_space_size` to be set by command line * move `examples/mmtk.h` to `docs/header/mmtk.h`. Building C code in `examples` no longer uses this header file. Related PRs: * mmtk/mmtk-openjdk#166 * mmtk/openjdk#12 * mmtk/mmtk-jikesrvm#118 * mmtk/mmtk-v8#64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.