CI: Run tests without ASLR #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boot images are built with the assumption that they will be loaded at a specific address. ASLR will cause some shared objects to be loaded at the addresses of the boot images, and the boot images will overwrite their sections, causing illegal instruction errors and other errors. This is a workaround. The proper fix is take control over the loading process and not let the system loader load shared objects in the address range of the boot image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boot images are built with the assumption that they will be loaded at a specific address. ASLR will cause some shared objects to be loaded at the addresses of the boot images, and the boot images will overwrite their sections, causing illegal instruction errors and other errors. This problem is easy to reproduce locally, and manifests very frequently when running on GitHub CI.
This PR modifies CI scripts to mitigate the problem. It adds
setarch -Rbefore executingrvmto disable ASLR.This PR is a workaround. The proper fix is take control over the loading process and not let the system loader load shared objects in the address range of the boot image.
Related issue: #158