Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'More' dropdown doesn't render properly on macOS with Safari #1295

Closed
scott-huberty opened this issue Aug 16, 2024 · 2 comments · Fixed by #1298
Closed

The 'More' dropdown doesn't render properly on macOS with Safari #1295

scott-huberty opened this issue Aug 16, 2024 · 2 comments · Fixed by #1298
Labels
bug

Comments

@scott-huberty
Copy link
Contributor

Description of the problem

I'm willing to help fix this, but I don't have a ton of experience customizing sphinx themes, and it may be a little while until I have time to dig into this.

Screen.Recording.2024-08-16.at.12.25.33.PM.mov

Steps to reproduce

See video (I'm using Safari on macOS Sonoma 14.5)

Expected results

I wanna see the dropdown!

Actual results

Can't see the dropdown 🙁

Additional information

See video.
@drammock
Copy link
Member

https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/header-links.html#navigation-bar-dropdown-links

Controlled by this variable in doc/conf.py

html_theme_options = {
  "header_links_before_dropdown": 5
}

(which is currently not set, and so is using the theme default value of 5). IDK why the dropdown is not showing, but the 2 things I'd try are updating the sphinx theme, and setting the above var to 6 (in the MNE-BIDS case, there are only 6 total top-level nav items (count the .. toctree entries in doc/index.rst), so currently in the dropdown there's only 1 (invisible) item which seems a bit pointless).

@scott-huberty
Copy link
Contributor Author

Thanks @drammock ! 🙏 I agree that a drop-down with only 1 item is potentially unnecessary. I’ll try it out and report back here or via PR.

scott-huberty added a commit to scott-huberty/mne-bids that referenced this issue Aug 21, 2024
@scott-huberty
FIX: explicitly set the number of items that should appear in the hea…
da3c745 
…der.

This suppresses a dropdown from kicking in after 5 items, effectively creating a dropdown with only 1 item.
Instead, this just shows all 6 items in the header bar.

Closes mne-tools#1295 , which raised an issue with the rendering of the dropdown. If a dropdown is ever introduced again, this issue may rear its head again.
@scott-huberty scott-huberty mentioned this issue Aug 21, 2024
Merged
7 tasks
sappelhoff pushed a commit that referenced this issue Aug 23, 2024
@scott-huberty
FIX: Workaround header dropdown rendering issue (#1298)
f919962 
* FIX: explicitly set the number of items that should appear in the header.

This suppresses a dropdown from kicking in after 5 items, effectively creating a dropdown with only 1 item.
Instead, this just shows all 6 items in the header bar.

Closes #1295 , which raised an issue with the rendering of the dropdown. If a dropdown is ever introduced again, this issue may rear its head again.

* FIX: html_theme_options already defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: Workaround header dropdown rendering issue scott-huberty/mne-bids
2 participants
@drammock @scott-huberty