FIX: Workaround header dropdown rendering issue #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der. This suppresses a dropdown from kicking in after 5 items, effectively creating a dropdown with only 1 item. Instead, this just shows all 6 items in the header bar. Closes mne-tools#1295 , which raised an issue with the rendering of the dropdown. If a dropdown is ever introduced again, this issue may rear its head again.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
==========================================
- Coverage 97.61% 97.45% -0.17%
==========================================
Files 40 40
Lines 8685 8716 +31
==========================================
+ Hits 8478 8494 +16
- Misses 207 222 +15 ☔ View full report in Codecov by Sentry. |
|
Rendering correctly on the built docs: 
|
scott-huberty
changed the title
|
wonderful, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1295
On the mne-bids website, this suppresses the dropdown from kicking in the header bar. Instead, this just shows all 6 items in the header bar (before, 5 items were shown in the header, 1 item in the dropdown menu).
If a dropdown is ever introduced again, the issue raised in #1295 may rear its head again.
Note
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: