Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update CIs and bump minimum to 3.8 #1108

Merged
merged 9 commits into from
Dec 6, 2022
Merged

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Dec 5, 2022

Closes #1107

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1108 (9d3af69) into main (abed5da) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
- Coverage   95.28%   95.23%   -0.06%     
==========================================
  Files          24       24              
  Lines        3900     3900              
==========================================
- Hits         3716     3714       -2     
- Misses        184      186       +2     
Impacted Files Coverage Δ
mne_bids/dig.py 97.92% <0.00%> (-0.35%) ⬇️
mne_bids/read.py 95.80% <0.00%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@larsoner larsoner changed the title MAINT: Update CIs MAINT: Update CIs and bump minimum to 3.8 Dec 5, 2022
@larsoner
Copy link
Member Author

larsoner commented Dec 5, 2022

@sappelhoff ready for CI branch protection rules to be updated and merged

@hoechenberger
Copy link
Member

hoechenberger commented Dec 5, 2022

Do we still support MNE 1.0? Latest stable is 1.2, I don't think we're even testing with 1.0 and 1.1 anymore, right?

@sappelhoff
Copy link
Member

sappelhoff commented Dec 5, 2022

+1 to upgrade to MNE 1.2 ... I tried to remove the scipy upgrade in 72bef09 because I felt like it should pass regardless ... apparently I was wrong.

I can take this over tomorrow, thanks a lot @larsoner

@hoechenberger
Copy link
Member

hoechenberger commented Dec 6, 2022

Oh I didn't realize we actually still test with MNE 1.0 -- but neither with 1.1 nor 1.2 (which were only implicitly covered for a while when testing with main)

+1 for bumping this to 1.2

setup.cfg Outdated Show resolved Hide resolved
@hoechenberger
Copy link
Member

Thanks @larsoner, seems I missed quite a few there!!!

@hoechenberger hoechenberger enabled auto-merge (squash) December 6, 2022 13:46
@hoechenberger hoechenberger merged commit 43e46f0 into mne-tools:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weird CI failure in schedules run: scipy build broken, "setuptools" missing
3 participants