Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update CIs and bump minimum to 3.8 #1108

Merged
merged 9 commits into from
Dec 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: ["3.7", "3.10"] # Oldest and newest supported versions
python-version: ["3.8", "3.10"] # Oldest and newest supported versions
steps:
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand All @@ -59,7 +59,7 @@ jobs:
- uses: actions/cache@v3
with:
path: ${{ env.pythonLocation }}
key: build-1-${{ env.pythonLocation }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('test_requirements.txt') }}
key: build-2-${{ env.pythonLocation }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('test_requirements.txt') }}

- name: Install dependencies
run: |
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04, ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.7", "3.10"] # Oldest and newest supported versions
python-version: ["3.8", "3.10"] # Oldest and newest supported versions
mne-version: [mne-stable]
bids-validator-version: [validator-stable]

Expand Down Expand Up @@ -144,23 +144,23 @@ jobs:
uses: actions/cache@v3
with:
path: ${{ env.pythonLocation }}
key: test-0-${{ env.pythonLocation }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('test_requirements.txt') }}
key: test-0-${{ env.pythonLocation }}-${{ env.os }}-${{ hashFiles('setup.cfg') }}-${{ hashFiles('test_requirements.txt') }}
sappelhoff marked this conversation as resolved.
Show resolved Hide resolved

- name: Install Python dependencies using pip
run: |
python -m pip install --upgrade pip
python -m pip install -r test_requirements.txt
python -m pip install --upgrade -r test_requirements.txt

- name: Install MNE (stable)
if: "matrix.mne-version == 'mne-stable'"
run: |
git clone --depth 1 --single-branch --branch maint/1.0 https://github.com/mne-tools/mne-python.git -b maint/1.0
git clone --depth 1 --single-branch --branch maint/1.2 https://github.com/mne-tools/mne-python.git
python -m pip install -e ./mne-python

- name: Install MNE (main)
if: "matrix.mne-version == 'mne-main'"
run: |
git clone --depth 1 --single-branch --branch main https://github.com/mne-tools/mne-python.git -b main
git clone --depth 1 --single-branch --branch main https://github.com/mne-tools/mne-python.git
python -m pip install -e ./mne-python

- name: Install BIDS validator (stable)
Expand Down
14 changes: 7 additions & 7 deletions doc/install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,22 @@ Dependencies

Required:

* ``mne`` (>=1.0)
* ``numpy`` (>=1.16.0)
* ``scipy`` (>=1.2.0, or >=1.5.0 for certain operations with EEGLAB data)
* ``mne`` (>=1.2)
* ``numpy`` (>=1.18.1)
* ``scipy`` (>=1.4.1, or >=1.5.0 for certain operations with EEGLAB data)
* ``setuptools`` (>=46.4.0)

Optional:

* ``nibabel`` (>=2.5, for processing MRI data)
* ``pybv`` (>=0.7.3, for writing BrainVision data)
* ``pymatreader`` (>=0.0.29 , for operations with EEGLAB data)
* ``pybv`` (>=0.7.5, for writing BrainVision data)
* ``pymatreader`` (>=0.0.30 , for operations with EEGLAB data)
* ``matplotlib`` (>=3.1.0, for using the interactive data inspector)
* ``pandas`` (>=0.24.0, for generating event statistics)
* ``pandas`` (>=1.0.0, for generating event statistics)
* ``EDFlib-Python`` (>=1.0.6, for writing EDF data)

We recommend the `Anaconda <https://www.anaconda.com/download/>`_ Python distribution.
We require that you **use Python 3.7 or higher**.
We require that you **use Python 3.8 or higher**.
You may choose to install ``mne-bids``
`via pip <#installation-via-pip>`_ or
`via conda <#installation-via-conda>`_.
Expand Down
3 changes: 2 additions & 1 deletion doc/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ Detailed list of changes
🛠 Requirements
^^^^^^^^^^^^^^^

- ...
- MNE-BIDS now requires Python 3.8 or higher, because Python 3.7 is soon reaching its end of life.
- MNE-BIDS now requires MNE-Python 1.2.0 or higher.

🪲 Bug fixes
^^^^^^^^^^^^
Expand Down
15 changes: 7 additions & 8 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ classifiers =
Operating System :: POSIX :: Linux
Operating System :: MacOS
Programming Language :: Python
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Expand All @@ -32,23 +31,23 @@ project_urls =
Source = https://github.com/mne-tools/mne-bids

[options]
python_requires = ~= 3.7
python_requires = ~= 3.8
install_requires =
mne >= 1.0
numpy >= 1.16.0
scipy >= 1.2.0
mne >= 1.2
numpy >= 1.18.1
scipy >= 1.4.1
setuptools
packages = find:
include_package_data = True

[options.extras_require]
full =
nibabel >= 2.5
pybv >= 0.7.3
pybv >= 0.7.5
matplotlib >= 3.1.0
pandas >= 0.24.0
pandas >= 1.0.0
EDFlib-Python >= 1.0.6
pymatreader >= 0.0.29
pymatreader >= 0.0.30

[options.entry_points]
console_scripts =
Expand Down
10 changes: 5 additions & 5 deletions test_requirements.txt
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
numpy>=1.16.0
numpy>=1.18.1
scipy>=1.5.0
mne>=1.0
mne>=1.2
matplotlib>=3.1
pandas>=0.24.0
pandas>=1.0.0
nibabel>=2.5
pybv>=0.7.3
pybv>=0.7.5
openneuro-py>=2022.2
EDFlib-Python>=1.0.6
pymatreader>=0.0.29
pymatreader>=0.0.30
pytest
pytest-cov
pytest-sugar
Expand Down