-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BTi handling in mne-bids #1160
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1160 +/- ##
=======================================
Coverage 97.62% 97.63%
=======================================
Files 40 40
Lines 8625 8655 +30
=======================================
+ Hits 8420 8450 +30
Misses 205 205
|
24618d9
to
d5c5f0a
Compare
Hi - sorry for only getting to this now. Yes, installing the latest devel versions of both mne and mne-bids have solved the BTi copying problems. Thanks! |
no worries, thanks @nugenta ... but did you install mne-bids from this branch? ... or just the mne-bids development version? anyhow, I am going to merge this now. Please update your mne-bids development version and tell us if it still works -- thanks! |
I think BTI copying was broken all this time in MNE-Python, I found several things that don't make any sense, and seemingly we never even had a test for this.
I now introduced a test. this code will only work with mne >= 1.5
@nugenta we need your help to test this fix.
Can you please:
mne
and then run your pipeline?
Are all your issues fixed?