ENH: Add pdf_fname to RawBTi._raw_extras #11851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
commented
Aug 1, 2023
Comment on lines
+190
to
+192
| # MNE-BIDS needs these | ||
| for key in ("pdf_fname", "config_fname", "head_shape_fname"): | ||
| assert os.path.isfile(ra._raw_extras[0][key]) |
There was a problem hiding this comment.
This is the only real addition to the tests
|
@sappelhoff feel free to review/mark for merge-when-green! |
sappelhoff
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
LGTM, thanks a lot @larsoner!
I'll make a PR to mne-bids soon :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11850
A private change just for the use of MNE-BIDS. Ideally we'd find some public way to do this but in the meantime the addition to the test with a comment saying MNE-BIDS needs the private attr is hopefully okay.
Split into two commits, the first modernizes the BTi tests using
pytest.mark.parametrizeand the second actually fixes #11850. In theory we could rebase+merge this then add to therevs-ignorebut it might not be worth it. I'll mark what I actually changed in the test...