MAINT: Updates to dependencies #227
Conversation
| - mne-bids =0.13.0 | ||
| - mne-bids =0.14 |
There was a problem hiding this comment.
cc @sappelhoff it seems like something went a bit off with the latest mne-bids release on conda-forge as it's 0.14 not 0.14.0. It's no problem here but figured you might want to look into this as it seems non-standard
There was a problem hiding this comment.
Thanks for the ping, but I don't think I understand the problem 🤔 AFAIK we always had versions like this:
- https://pypi.org/project/mne-bids/#history
- https://github.com/conda-forge/mne-bids-feedstock/commits/main/recipe/meta.yaml
I.e., we drop the trailing patch version of .0 if it is a zero, and only append if it is >= .1
There was a problem hiding this comment.
Seems like it might be non-standard behavior to do that. Or at least I noticed that MNE-BIDS is the only package in this list that versions that way. Based on a tiny bit of SemVer reading just now it sounds like it's better in general to have the .0 at the end if it's not a pain to add it
There was a problem hiding this comment.
That's a good point, thanks. I believe we took the versioning system from mne-python though --> isn't that how releases were usually done? The history seems to agree for mne versions <0.17.
It seems like we've missed a "change" in how versions are being done at mne, because since about 0.17 (it's inconsistent on pypi and github), there is always the .0 patch addendum.
cc @hoechenberger @jasmainak @agramfort
- https://github.com/mne-tools/mne-python/tags?after=v0.19.1
- https://pypi.org/project/mne/#history
I am not sure what to do now. Shall we just adjust the mne-bids versioning protocol for future versions? So far we haven't had any issues with the current scheme.
There was a problem hiding this comment.
I don't think we ever did a patch release for MNE-BIDS, or did we? I'm okay with leaving things as they are, i.e., just MAJOR.MINOR
In fact, we could even drop the 0. and just use current MINOR as the only (MAJOR) version number, would be closer to SemVer anyway :)
There was a problem hiding this comment.
Ah, we had MNE-BIDS 0.11.1 once :)
There was a problem hiding this comment.
I don't think we ever did a patch release for MNE-BIDS, or did we
we do have two patch releases, one of them being: https://github.com/mne-tools/mne-bids/releases/tag/v0.11.1
I am +1 to adding the .0 from now on, and being more semver-ish
Draft until we can actually change to 1.6, just making sure stuff is green in the meantime