Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Updates to dependencies #227

Merged
merged 3 commits into from
Nov 20, 2023
Merged

MAINT: Updates to dependencies #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5520314
MAINT: Update to 1.6
larsoner Nov 20, 2023
b596f38
FIX: Again
larsoner Nov 20, 2023
bc5c152
FIX: Ver
larsoner Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions recipes/mne-python/construct.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ specs:
- pip =23.3.1
- conda =23.10.0
- mamba =1.5.3
- conda-libmamba-solver =23.11.0
- conda-libmamba-solver =23.11.1
# MNE ecosystem
# TODO: ⛔️ ⛔️ ⛔️ DEV BUILDS START: CHANGE BEFORE RELEASE! ⛔️ ⛔️ ⛔️
# - mne =1.4dev0=*_20230503
Expand All @@ -75,7 +75,7 @@ specs:
- mne-installer-menus =1.5.1=*_0
# For testing purposes with build_local.sh, you can comment out all deps
# below for speed, and change mne to mne-base above
- mne-bids =0.13.0
- mne-bids =0.14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @sappelhoff it seems like something went a bit off with the latest mne-bids release on conda-forge as it's 0.14 not 0.14.0. It's no problem here but figured you might want to look into this as it seems non-standard

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, but I don't think I understand the problem 🤔 AFAIK we always had versions like this:

I.e., we drop the trailing patch version of .0 if it is a zero, and only append if it is >= .1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it might be non-standard behavior to do that. Or at least I noticed that MNE-BIDS is the only package in this list that versions that way. Based on a tiny bit of SemVer reading just now it sounds like it's better in general to have the .0 at the end if it's not a pain to add it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point, thanks. I believe we took the versioning system from mne-python though --> isn't that how releases were usually done? The history seems to agree for mne versions <0.17.

It seems like we've missed a "change" in how versions are being done at mne, because since about 0.17 (it's inconsistent on pypi and github), there is always the .0 patch addendum.

cc @hoechenberger @jasmainak @agramfort

I am not sure what to do now. Shall we just adjust the mne-bids versioning protocol for future versions? So far we haven't had any issues with the current scheme.

Copy link
Member

@hoechenberger hoechenberger Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we ever did a patch release for MNE-BIDS, or did we? I'm okay with leaving things as they are, i.e., just MAJOR.MINOR

In fact, we could even drop the 0. and just use current MINOR as the only (MAJOR) version number, would be closer to SemVer anyway :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we had MNE-BIDS 0.11.1 once :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we ever did a patch release for MNE-BIDS, or did we

we do have two patch releases, one of them being: https://github.com/mne-tools/mne-bids/releases/tag/v0.11.1

I am +1 to adding the .0 from now on, and being more semver-ish

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me!!

- mne-bids-pipeline =1.4.0
- mne-qt-browser =0.6.1
- mne-connectivity =0.5.0
Expand All @@ -88,7 +88,7 @@ specs:
- mne-kit-gui =1.1.0
- mne-icalabel =0.5.1
- mne-gui-addons =0.1.0
- mne-lsl =1.0.0
- mne-lsl =1.1.0
- traitsui =8.0.0
- autoreject =0.4.3
- pyriemann =0.5
Expand All @@ -99,7 +99,7 @@ specs:
- openblas =0.3.24
- libblas =3.9.0=*openblas
- jupyter =1.0.0
- jupyterlab =4.0.8
- jupyterlab =4.0.9
- ipykernel =6.26.0
- nb_conda_kernels =2.3.1
- spyder-kernels =2.5.0
Expand All @@ -115,7 +115,7 @@ specs:
# Statistics
- pingouin =0.5.3
# MRI
- fsleyes =1.10.0
- fsleyes =1.10.1
- dcm2niix =1.0.20230411
# Time-frequency analysis
- pactools =0.3.1
Expand Down Expand Up @@ -152,7 +152,7 @@ specs:
- pyvista =0.42.3
- pyvistaqt =0.11.0
- trame =3.3.0
- trame-vtk =2.6.1
- trame-vtk =2.6.2
- trame-vuetify =2.3.1
- termcolor =2.3.0
# Development
Expand All @@ -163,7 +163,7 @@ specs:
- pytest-harvest =1.10.4
- pytest-timeout =2.2.0
- pre-commit =3.5.0
- ruff =0.1.5
- ruff =0.1.6
- black =23.10.1
- check-manifest =0.49.0
- codespell =2.2.6
Expand All @@ -177,7 +177,7 @@ specs:
- pydata-sphinx-theme =0.13.3
- graphviz =8.1.0
- python-graphviz =0.20.1
- selenium =4.15.1
- selenium =4.15.2
- sphinx-design =0.5.0
- sphinx-gallery =0.14.0
- sphinxcontrib-bibtex =2.6.1
Expand Down
1 change: 1 addition & 0 deletions tests/test_outdated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class Package: # noqa: D101
allowed_outdated: set[str] = {
"python", # ignore 3.12.0rc3
"tensorflow", # 2.13.1 conflicts with VTK
"graphviz", # conflicts with VTK
"pydata-sphinx-theme", # haven't updated to latest version in our conf.py
}
packages: list[Package] = []
Expand Down