Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: mne.get_config #1112

Closed
dengemann opened this issue Jan 31, 2014 · 6 comments · Fixed by #1135
Closed

API: mne.get_config #1112

dengemann opened this issue Jan 31, 2014 · 6 comments · Fixed by #1135

Comments

@dengemann
Copy link
Member

should be callable without arguments and should return all mappings

@agramfort
Copy link
Member

+1

On Fri, Jan 31, 2014 at 6:20 PM, Denis A. Engemann <notifications@github.com

wrote:

should be callable without arguments and should return all mappings

Reply to this email directly or view it on GitHubhttps://github.com//issues/1112
.

@saketkc
Copy link
Contributor

saketkc commented Feb 16, 2014

Should it return a json object?

@dengemann
Copy link
Member Author

@saketkc simply a dictionary. Once you open a json file and represent it's contents in Python what you get is a dict.

@larsoner
Copy link
Member

I think a dict would probably be more convenient.

@saketkc
Copy link
Contributor

saketkc commented Feb 16, 2014

Yes, my choice of json was a bit off, that's what I meant :)

@dengemann
Copy link
Member Author

@saketkc anyways, PR welcome :-) We can think about adding custom representations should we come to the conclusion that returning all json mappings as a dict is messy. E.g. as we did it with info objects https://github.com/mne-tools/mne-python/blob/master/mne/fiff/meas_info.py#L37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants