Enhance API:mne.get_config to return config dict when called wthout para... #1135
Conversation
| The preference key to look for. The os evironment is searched first, | ||
| then the mne-python config file is parsed. | ||
| If None, all the config parameters present in the path are returned |
|
What's the unicode problem? They come in as unicode strings? I think that's okay... |
|
There is a failure on 3.3 BTW. |
|
@saketkc could elaborate the unicode issue? I would expect this to be handled at the json level. If not conversion using |
| key = 'MNE_PYTHON_TESTING_KEY' | ||
| config = {key: value} | ||
| set_config(key, value, home_dir=tempdir) | ||
| assert_equal(get_config(home_dir=tempdir), config) |
There was a problem hiding this comment.
this returns None for some reason in Python 3.3.
There was a problem hiding this comment.
Not able to figure this one out.
There was a problem hiding this comment.
For some reason, python3.3 seems to check if key is in os.environ : https://travis-ci.org/mne-tools/mne-python/jobs/19015348#L2301
There was a problem hiding this comment.
Fixing this, was too trivial, don't know how I missed.
|
can I merge this? |
|
👍 from me :) |
Enhance API:mne.get_config to return config dict when called wthout para...
|
Thanks @saketkc ! This will make people happy. |
|
So true @dengemann :) |
|
Btw. @saketkc works like a charm on my box across different Pythons. Beautiful. |
Fixes #1112. Comments required for json unicode encoding, commented as of now.
Also added tests.