Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trace offsets in butterfly mode #10087

Merged
merged 2 commits into from
Dec 3, 2021
Merged

fix trace offsets in butterfly mode #10087

merged 2 commits into from
Dec 3, 2021

Conversation

drammock
Copy link
Member

@drammock drammock commented Dec 3, 2021

closes #10083

@drammock drammock added the VIZ label Dec 3, 2021
hoechenberger
hoechenberger approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, this works for me!

Can you add a changelog entry please?

@hoechenberger hoechenberger added the backport-candidate on-merge: backport to maint/1.7 label Dec 3, 2021
larsoner
larsoner approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 for merge, whoever sees green first feel free to click the button

@drammock drammock merged commit 9dff616 into mne-tools:main Dec 3, 2021
@drammock drammock deleted the fix-butterfly-chorder branch December 3, 2021 22:02
larsoner added a commit to GuillaumeFavelier/mne-python that referenced this pull request Dec 6, 2021
@larsoner
Merge remote-tracking branch 'upstream/main' into enh/coreg_feats
28773f4 
* upstream/main:
  Use fixes._compare_version for version checks everywhere (mne-tools#10091)
  Fast annotation from mask (mne-tools#10089)
  fix trace offsets in butterfly mode (mne-tools#10087)
  fix plot_compare_evokeds topo legend axes placement (mne-tools#9927)
  doc: clarify ica.apply include and exclude params (mne-tools#10086)
  MRG: Make y a required parameter in CSP.fit_transform() (mne-tools#10084)
  Add scrollbar to report tag dropdown menu (mne-tools#10082)
@larsoner
Copy link
Member

larsoner commented Dec 6, 2021

@drammock it looks like this broke circleci:

Traceback (most recent call last):
  File "/home/circleci/project/tutorials/epochs/20_visualize_epochs.py", line 79, in <module>
    epochs['face'].plot(events=catch_trials_and_buttonpresses, event_id=event_dict,
  File "/home/circleci/project/mne/epochs.py", line 1136, in plot
    return plot_epochs(self, picks=picks, scalings=scalings,
  File "/home/circleci/project/mne/viz/epochs.py", line 915, in plot_epochs
    fig._draw_traces()
  File "/home/circleci/project/mne/viz/_mpl_figure.py", line 1721, in _draw_traces
    offsets = self.mne.trace_offsets[offset_ixs]
IndexError: index 364 is out of bounds for axis 0 with size 364

@drammock
Copy link
Member Author

drammock commented Dec 6, 2021

on it.

@drammock drammock mentioned this pull request Dec 6, 2021
Merged
@larsoner larsoner removed the backport-candidate on-merge: backport to maint/1.7 label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoechenberger hoechenberger hoechenberger approved these changes

@larsoner larsoner larsoner approved these changes

Assignees
No one assigned
Labels
VIZ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertical placement of channel traces seems off in raw butterfly plot
3 participants
@drammock @larsoner @hoechenberger