Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trace offsets in butterfly mode #10087

Merged
merged 2 commits into from
Dec 3, 2021
Merged

fix trace offsets in butterfly mode #10087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feacd02
fix trace offsets in butterfly mode
drammock Dec 3, 2021
155ffc2
changelog entry
drammock Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/changes/latest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ Bugs

- Fix :func:`~mne.stats.permutation_cluster_1samp_test` to properly handle 2-dimensional data in combination with TFCE (:gh:`10073` by `Richard Höchenberger`_)

- Fix channel grouping error when using "butterfly mode" with :meth:`mne.io.Raw.plot` (:gh:`10087` by `Daniel McCloy`_)

- Fix bug that appears during automatic calculation of the colormap of `mne.viz.Brain` when data values of ``fmin`` and ``fmax`` are too close (:gh:`10074` by `Guillaume Favelier`_)

API changes
Expand Down
4 changes: 3 additions & 1 deletion mne/viz/_mpl_figure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1717,6 +1717,8 @@ def _draw_traces(self):
picks = self.mne.picks
ch_names = self.mne.ch_names[picks]
ch_types = self.mne.ch_types[picks]
offset_ixs = picks if self.mne.butterfly else slice(None)
offsets = self.mne.trace_offsets[offset_ixs]
bad_bool = np.in1d(ch_names, self.mne.info['bads'])
# colors
good_ch_colors = [self.mne.ch_color_dict[_type] for _type in ch_types]
Expand Down Expand Up @@ -1785,7 +1787,7 @@ def _draw_traces(self):
for ii, line in enumerate(self.mne.traces):
this_name = ch_names[ii]
this_type = ch_types[ii]
this_offset = self.mne.trace_offsets[ii]
this_offset = offsets[ii]
this_times = decim_times[decim[ii]]
this_data = this_offset - self.mne.data[ii] * self.mne.scale_factor
this_data = this_data[..., ::decim[ii]]
Expand Down