[MRG] FIX: snirf length units #10613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I implemented the same fix in #10611, so I think it's a pretty good fix 😉. But let's get this merged as it might be faster than getting my pr approved that had a few other things that might have a review cycle. |
|
Do we need a changelog entry? |
hoechenberger
approved these changes
May 8, 2022
|
Thanks @sappelhoff |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
May 9, 2022
* upstream/main: MRG: Add "highlight" parameter to Evoked.plot() to conveniently highlight time periods (mne-tools#10614) MRG: Allow to pass array of "average" values to plot_evoked_topomap() (mne-tools#10610) fix: snirf length units (mne-tools#10613) minor, doc: fix subplot titles in tutorial (mne-tools#10607) Display averaged time period in Evoked topomap title (mne-tools#10606) MAINT: Fix for pydata-sphinx-theme [skip azp][skip actions][circle deploy] (mne-tools#10605) DOC: report.add_html in tutorial (mne-tools#10603) Broader support of the SNIRF file format and enable reading GowerLab data (mne-tools#10555) MRG: Recommend mamba instead of libmamba for installation (mne-tools#10597) Fix dev documentation warning [skip azp][skip actions] (mne-tools#10599) FIX cmap (mne-tools#10593) [ENH, MRG] Add interpolate bridged electrodes function (mne-tools#10587)
larsoner
added a commit
to HanBnrd/mne-python
that referenced
this pull request
May 17, 2022
* upstream/main: (24 commits) Use less memory when loading EDF file (mne-tools#10638) BUG: fix ipython console accessibility after MNEQtBrowser in Spyder (mne-tools#10637) WIP: Fix mne.time_frequency.multitaper Nyquist adjustment slightly incorrect (mne-tools#10541) BUG: Fix bug with fNIRS reordering (mne-tools#10630) MNT: PyQt6 for pip pre 3.10 (mne-tools#10636) CI: Fix conda (mne-tools#10628) MRG: Update installer links to point to 1.0.3_0 (mne-tools#10622) [BUG, MRG] fix info write access (mne-tools#10626) [MRG] Fixed group_by titles in evoked_plot. (mne-tools#10618) [BUG, MRG] Replace image_interp with interpolation in topomap plot arguments (mne-tools#10617) MAINT: Fix timeout (mne-tools#10624) Simplify mne-tools#10619 (mne-tools#10620) Drop EEG rejection thresholds when replacing EEG with CSD channels (mne-tools#10619) Add get_montage support for fNIRS (mne-tools#10611) ENH: Improve make_head_surface options (mne-tools#10592) [ENH, MRG] Add citation for intracranial JOSS paper (mne-tools#10616) [ENH] Add sys info for mne-icalabel (mne-tools#10615) MRG: Add "highlight" parameter to Evoked.plot() to conveniently highlight time periods (mne-tools#10614) MRG: Allow to pass array of "average" values to plot_evoked_topomap() (mne-tools#10610) fix: snirf length units (mne-tools#10613) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this because the mne-bids CI failed. These are probably reasonable fixes, wdyt @rob-luke?
https://github.com/mne-tools/mne-bids/runs/6338742975?check_suite_focus=true#step:15:400