-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating TFR classes #11282
updating TFR classes #11282
Conversation
I have a couple of questions:
|
They will be retained, possibly with some signature changes in their
IIUC, because it's computationally expensive and wasn't viewed as a desired/useful use case. But in recent years a few folks have asked for it, so we're adding it. |
619a10c
to
a2fb353
Compare
15276be
to
9145025
Compare
1188617
to
c1e5869
Compare
a659480
to
db5fd57
Compare
15f2ad3
to
e1c5962
Compare
916ec19
to
365878c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
a07af96
to
ae76b38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I briefly ran the new methods on the sample dataset, and it was very intuitive! I'm looking forward to using this new API! A couple of nitpick/changes which could improve the documentation clarity. Thank you @drammock!
TODO: changed examples
|
some of the changed examples mentioned above ☝🏻 are caused by the fact that
That discovery makes it easy enough to preserve the tutorial plots unchanged... but it seems really weird to have opposite defaults for |
That seems like it's likely a bug but we should maybe fix via deprecation. IIRC |
digging deeper, I found this docstring on the private internal
Which looks pretty intentional... but still, the function ( |
46c9954
to
4ad2812
Compare
OK I think I've resolved all the non-matching tutorial plots now! Note that in 5ea9cc7 I also did what I think is a simplification/improvement to the Hilbert example in
@larsoner I'd appreciate a look at just that commit to make sure you agree with that change. The resulting plot does change a little (PR vs main) but in a way that I think makes it more accurate and realistic. |
failure on ubuntu minimal is unrelated: a GitHub timeout when checking for latest release in the |
Checked the example and it looks okay, restarted the problematic CI run and marked for merge-when-green, thanks in advance @drammock ! |
WIP.The goal here is to copy the new Spectrum API into the time-frequency analysis code. Briefly this means (1) a new classRawTFR
, (2) new instance methods[raw,epochs,evoked].compute_tfr()
, (3) legacy-ify old API entry pointstfr_morlet
,tfr_multitaper
, andtfr_stockwell
(thetfr_array_*
functions will remain), and (4) flesh out / make more consistent the API of the*TFR
classes.compute_tfr()
RawTFR
class__init__
__init__
s in thecompute_tfr()
methodstfr_*
functions