Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating TFR classes #11282

Merged
merged 53 commits into from
Mar 20, 2024
Merged

updating TFR classes #11282

merged 53 commits into from
Mar 20, 2024

Commits on Feb 28, 2024

  1. overhaul TFR classes

    refactor method_kw checking
    
    cleaner imports
    
    refactor _get_instance_type_string
    
    many changes; raw.compute_tfr(multitaper, freqs) works!
    
    add verbose to tfr_array_stockwell
    
    add get_data() method
    
    DRY / fixes for method=stockwell
    
    partially handle ITC; comments
    
    forgotten (temporary) import
    
    rework evoked fixtures to provide uncropped evoked option
    
    override plot() method for EpochsTFR
    
    add nave to save/load roundtrip
    
    move copy to base class, fix docstrings, work on iter_evoked
    
    work on ITC handling; add ValueErrors for unsupported param combos; cleanup TODOs
    
    move arg gymnastics into EpochsTFR init; get iter_evoked working
    
    get TFR.average() working
    
    working on making stockwell/ITC behave sanely
    
    reorg for saner class behavior
    
    cleanup/move util funcs
    
    make plotting work for singleton EpochsTFR
    
    docstring fixes; support comments for AverageTFR
    
    fix stockwell bugs
    
    fix attributes, fix docstring format, don't store method_kw in an attribute
    
    fix import nesting
    
    add forgotten utils file
    
    add arithmetic methods
    
    fix check_option for stockwell
    
    get baseline and crop working
    
    add loader func; allow both h5 and hdf5 extensions
    
    get plot_topomap working
    
    better decim support for stockwell
    
    make read_tfrs always return new class
    
    refactor plot_joint
    
    get plot_joint interaction working for grads; propogate topomap_kw to popup figs
    
    small improvements to util func set_title_multi_electrodes
    
    get onselect topomaps to look like plot_joint topomaps
    
    copy everything to tfr.py; delete spectrogram.py; mark legacy
    
    plot_joint debugging
    
    attr docstrings, docstring fixes, RawTFRArray, pass inst as kwarg
    
    improve test of tfr.plot_topomap
    
    WIP docstring dedup [ci skip]
    
    consolidate tests; provide 2 sizes of AverageTFR fixtures
    
    simplify plot_joint and fix pick handling for onselect topomap
    
    fix and test repr_html
    
    improve coverage
    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    816d75a View commit details
    Browse the repository at this point in the history
  2. fixup after rebase

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8e0c76c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    412c151 View commit details
    Browse the repository at this point in the history
  4. make test less hacky

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    01c39d3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b301d1d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2969301 View commit details
    Browse the repository at this point in the history
  7. fix old/compat tests

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6cdf01c View commit details
    Browse the repository at this point in the history
  8. fix doc build errors

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b711529 View commit details
    Browse the repository at this point in the history
  9. misc typo

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b5819e7 View commit details
    Browse the repository at this point in the history
  10. rename test

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    2a8305f View commit details
    Browse the repository at this point in the history
  11. remove redundant test

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    762fc5f View commit details
    Browse the repository at this point in the history
  12. fix metadata round-trip

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    80494eb View commit details
    Browse the repository at this point in the history
  13. more tutorial/example fixes

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d31aeb3 View commit details
    Browse the repository at this point in the history
  14. fix import problem

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e630745 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    212da92 View commit details
    Browse the repository at this point in the history
  16. test post-decimation

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    90be26c View commit details
    Browse the repository at this point in the history
  17. remove redundant test

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1e30e47 View commit details
    Browse the repository at this point in the history
  18. handle complex output

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    afc478a View commit details
    Browse the repository at this point in the history
  19. cleanups after self-review

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9d2b720 View commit details
    Browse the repository at this point in the history
  20. make BaseTFR public

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    77137b5 View commit details
    Browse the repository at this point in the history
  21. undo introduced bug

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c0223d1 View commit details
    Browse the repository at this point in the history
  22. remove cruft

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f610de5 View commit details
    Browse the repository at this point in the history
  23. docstring/comment fixes

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3fd8b20 View commit details
    Browse the repository at this point in the history
  24. fix backcompat

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8a34570 View commit details
    Browse the repository at this point in the history
  25. move test to minimize diff

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f766fc0 View commit details
    Browse the repository at this point in the history
  26. fix decoding test fail

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    fb4977a View commit details
    Browse the repository at this point in the history
  27. fix docstring test

    drammock committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5ee3263 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    91fa2f1 View commit details
    Browse the repository at this point in the history
  2. fix test

    drammock committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c6d7218 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c30d1b View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Apply suggestions from code review [ci skip]

    Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
    drammock and larsoner authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    8f7c4a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a303b38 View commit details
    Browse the repository at this point in the history
  3. obligate kwarg now

    drammock committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e35e79e View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    d87aee8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e09d3c0 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Configuration menu
    Copy the full SHA
    496958f View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. fix docstring: freqs param

    drammock committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    00a7e71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a51331 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa8dc6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    17f1891 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Configuration menu
    Copy the full SHA
    4ad2812 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f5eb407 View commit details
    Browse the repository at this point in the history
  3. avoid futurewarning in tests

    drammock committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f4c98b7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    69066c9 View commit details
    Browse the repository at this point in the history
  5. fix docdict order

    drammock committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    891ffcb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1723c2f View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. warn once, not twice

    drammock committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    7b27c86 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c9dcc6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    567e7f3 View commit details
    Browse the repository at this point in the history
  4. fix hilbert plots in example

    drammock committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ae4c5ec View commit details
    Browse the repository at this point in the history
  5. less confusing fallback repr

    drammock committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f76e6b4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5ea9cc7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    714c14b View commit details
    Browse the repository at this point in the history