-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: use lazy loading #11838
ENH: use lazy loading #11838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward and stays readable, nice!
so basically a 2x difference? @drammock did you sort out the issue of scipy module if we don't nest the imports? |
I'm not totally sure what this refers to... but my expectation is that this |
That's what I expect too @larsoner. I got partway through the unnesting work and will finish it tomorrow and push the results |
IIUC the |
* upstream/main: MAINT: Split FIFF I/O into private submodule (mne-tools#11903)
* upstream/main: MAINT: Move underscores (mne-tools#11914)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drammock I think this one is finally ready!
* upstream/main: BUG: Fix bug with snirf birthday (mne-tools#11912)
mne/utils/__init__.py
Outdated
# # # WARNING # # # | ||
# This list must also be updated in doc/_templates/autosummary/class.rst if it | ||
# is changed here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this comment now cruft?
Thanks @drammock I'll push a commit with those fixes soon |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Proof of concept for adopting SPEC 1.
~380 ms on
main
:~205 ms on this PR after only converting
mne/__init__.py
(i.e. all the other__init__
files unchanged):Todo:
EAGER_IMPORT=true
env var to smoke out circular import issues__init__.py
EAGER_IMPORT=true
)mne/io/__init__.py
and convertmne/fiff/__init__.py