MAINT: Split FIFF I/O into private submodule #11903
Conversation
|
FYI, I added autoreject to the list of sibling packages to check. |
|
|
||
|
|
||
| @verbose | ||
| def is_equal(first, second, verbose=None): |
There was a problem hiding this comment.
This was intentionally removed. I had never seen it before, it was never used anywhere AFAIK
* upstream/main: Small splits fix (mne-tools#11905) adds niseq package to "Related software" (mne-tools#11909) Minor fixes for ERDS maps example (mne-tools#11904)
| __all__ = [ | ||
| # mne-bids, autoreject, mne-connectivity, mne-realtime, mne-nirs, mne-realtime | ||
| "_picks_to_idx", | ||
| # mne-qt-browser | ||
| "_DATA_CH_TYPES_ORDER_DEFAULT", | ||
| "_DATA_CH_TYPES_SPLIT", | ||
| ] |
There was a problem hiding this comment.
@drammock other than mne.io.constants.FIFF (which is pretty painless to keep) this is the list of what we have to keep around to make sibling packages happy. Do you think we should make some variant of _picks_to_idx public?
There was a problem hiding this comment.
yes I do. I notice it was used in MNE-BIDS and it's a pretty common thing to want to do (I believe @Aaronearlerichardson mentioned something about it in #11899 today in fact)
There was a problem hiding this comment.
Okay we'll probably need to think a little bit about how to do that correctly, I'll open a separate issue
|
Okay to merge @drammock ? |
* upstream/main: MAINT: Split FIFF I/O into private submodule (mne-tools#11903)
First part is almost done I think -- just need to see what fails to tie up a few remaining loose ends that I'm sure CIs will reveal:
mne/iotomne/_fiffmne/io/*.pythat movedThe next phase will be a bit more work -- moving sibling MNE-* packages to use only public APIs if possible. This will probably require adding some new functions, but we'll see.
Then:
git mvthemne/io/_*.pytomne/io/*.py(doing it in one PR makes a horrible diff!)Helpful for #11838 but cleans things up in its own right.