-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix device selection #1953
Fix device selection #1953
Conversation
f768799
to
e278c70
Compare
e278c70
to
2a4692a
Compare
Another false positive of #2005... |
# Conflicts: # maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt
I tested this and it seems the issue is not fixed, i.e. Maestro still doesn't ask what device to run on when more than 1 device is connected. To reproduce, start 2 android emulators, and then:
|
Aside from that it looks good. Also thanks a ton for resolving all merge conflicts! |
Ugh, more conflicts after I merged #1995 |
# Conflicts: # maestro-cli/src/main/java/maestro/cli/command/TestCommand.kt
I think it's OK to not do this. Actually, I don't like that Maestro CLI can create new devices as part of |
Yeah I fully agree |
@bartekpacia I got rid of device creation. I also switched |
This is awesome. Thank you. Re: |
This reverts commit 9238f97.
Proposed changes
Testing
Issues fixed
Fixes #1849