-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --shard-all
and --shard-split
options to test command
#1955
Conversation
c06699b
to
a1c86b2
Compare
Let's start with this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not breaking anything as it only affects cases where both Here's a recap. Let's say we have 3 launched devices.
|
I see, this makes sense! Perhaps it'd be great to add this to the docs. Also heads up that the E2E test is failing. |
Test failing is false positive from #2005 |
91e817c
to
fadf7a7
Compare
- Deprecate `--shards` - Introduce `--shard-split` and `--shard-all`
Another false positive from #2005. They are getting more and more crazy: |
--shard-all
and --shard-split
options to test command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes
--shards
but respects--device
Testing
maestro test -b
on a folder with multiple flowsIssues fixed
Fixes #1844