Add `mutex.rs` to `mc-sgx-sync` crate #40

nick-mobilecoin · 2023-01-17T20:12:08Z

Add mutex.rs implementation which more or less copies from
rust source at
606c3907

nick-mobilecoin · 2023-01-17T20:12:36Z

Current dependencies on/for this PR:

main
- PR Update CI for SGX SDK action update #14
  - PR Move panic to panic/abort #13
    - PR Add untrusted side of stderr from enclave #15
      - PR Add mc-sgx-io #22
        
        PR Add mc-sgx-panic-log #24
        
        PR Add mc-sgx-panic crate for common panic handling #30
        
        PR Add panicking::panic_count to mc-sgx-panic #31
        
        PR Update CODEOWNERS file #32
        
        PR Add panicking::panicking() function #33
        PR Add public function thread::panicking() #34
        PR Add mc-sgx-sync crate #35
        PR Add poison.rs to mc-sgx-sync crate #36
        PR Add sys module to mc-sgx-sync #39
        PR Add mutex.rs to mc-sgx-sync crate #40 👈
        PR Use a static buffer for panic messages #41
        PR Add mc-sgx-sync::sys::locks::Condvar #42
        PR Add Condvar to mc-sgx-sync crate #43
        PR Add mc-sgx-sync::sys::locks::RwLock #44
        PR Add RwLock to mc-sgx-sync #45
        PR Add example usage for mc-sgx-sync and std::sync #46
        PR Merge panic-abort and panic-log crates into mc-sgx-panic #48
        PR Prevent recursive panics from happening #50
        PR Remove unneeded traits on sys types #51
      - PR Rename mc-sgx-io to mc-sgx-io-untrusted #21

This comment was auto-generated by Graphite.

codecov-commenter · 2023-01-18T01:21:32Z

Codecov Report

❗ No coverage uploaded for pull request base (nick/sys-mutex@0947923). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                Coverage Diff                @@
##             nick/sys-mutex      #40   +/-   ##
=================================================
  Coverage                  ?   91.91%           
=================================================
  Files                     ?        7           
  Lines                     ?      235           
  Branches                  ?        0           
=================================================
  Hits                      ?      216           
  Misses                    ?       19           
  Partials                  ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sync/src/mutex.rs

Add `mutex.rs` implementation which more or less copies from [rust source](https://github.com/rust-lang/rust.git) at [606c3907](rust-lang/rust@606c390)

Also fix some typos

Update the root module for `sync/src/sys/locks` to match newer rust file naming convention, https://doc.rust-lang.org/reference/items/modules.html#module-source-filenames

nick-mobilecoin · 2023-01-30T22:58:32Z

@varsha888 bumping for re-review due to restack

nick-mobilecoin · 2023-01-30T23:47:18Z

✅ This pull request merged successfully as part of a Graphite job
Stack job ID: rnb0zcLhVk2UL31G5ihD.
See details on graphite.dev

This was referenced Jan 17, 2023

Update CI for SGX SDK action update #14

Merged

Move panic to panic/abort #13

Merged

github-actions bot requested review from samdealy and varsha888 January 17, 2023 20:12

nick-mobilecoin mentioned this pull request Jan 17, 2023

Add untrusted side of stderr from enclave #15

Merged

github-actions bot assigned nick-mobilecoin Jan 17, 2023

nick-mobilecoin mentioned this pull request Jan 17, 2023

Rename mc-sgx-io to mc-sgx-io-untrusted #21

Closed

github-actions bot added the size/L Large PRs label Jan 17, 2023

nick-mobilecoin force-pushed the nick/sys-mutex branch from 1d47a22 to 6cb3d9e Compare January 17, 2023 20:18

nick-mobilecoin requested a review from jcape as a code owner January 17, 2023 20:18

nick-mobilecoin force-pushed the nick/mutex branch from 538e33b to 08c5aef Compare January 17, 2023 20:21

This was referenced Jan 23, 2023

Use a static buffer for panic messages #41

Merged

Thread (mc-sgx-sync) #29

Closed

samdealy approved these changes Jan 23, 2023

View reviewed changes

sync/src/mutex.rs Show resolved Hide resolved

sync/src/mutex.rs Outdated Show resolved Hide resolved

sync/src/mutex.rs Outdated Show resolved Hide resolved

sync/src/mutex.rs Show resolved Hide resolved

sync/src/mutex.rs Outdated Show resolved Hide resolved

nick-mobilecoin force-pushed the nick/sys-mutex branch from 6cb3d9e to a109b8a Compare January 24, 2023 16:03

nick-mobilecoin force-pushed the nick/mutex branch from 68452c6 to 52f6ca9 Compare January 24, 2023 16:03

varsha888 approved these changes Jan 24, 2023

View reviewed changes

nick-mobilecoin mentioned this pull request Jan 24, 2023

Add mc-sgx-sync::sys::locks::Condvar #42

Merged

This was referenced Jan 25, 2023

Add Condvar to mc-sgx-sync crate #43

Merged

Add mc-sgx-sync::sys::locks::RwLock #44

Merged

Add RwLock to mc-sgx-sync #45

Merged

nick-mobilecoin force-pushed the nick/mutex branch 2 times, most recently from f230937 to 38f18fa Compare January 26, 2023 15:32

This was referenced Jan 27, 2023

Add example usage for mc-sgx-sync and std::sync #46

Merged

Merge panic-abort and panic-log crates into mc-sgx-panic #48

Merged

nick-mobilecoin force-pushed the nick/sys-mutex branch from 50bfc5b to 329ce0a Compare January 30, 2023 22:53

nick-mobilecoin force-pushed the nick/mutex branch from 38f18fa to edfdcb1 Compare January 30, 2023 22:53

nick-mobilecoin added 3 commits January 30, 2023 14:56

Add mutex.rs to mc-sgx-sync crate

7aebc10

Add `mutex.rs` implementation which more or less copies from [rust source](https://github.com/rust-lang/rust.git) at [606c3907](rust-lang/rust@606c390)

Remove inline usage

fc92d67

Also fix some typos

Move sync/src/sys/locks/mod.rs to sync/src/sys/locks.rs

dc33a43

Update the root module for `sync/src/sys/locks` to match newer rust file naming convention, https://doc.rust-lang.org/reference/items/modules.html#module-source-filenames

nick-mobilecoin force-pushed the nick/sys-mutex branch from 329ce0a to 0947923 Compare January 30, 2023 22:56

nick-mobilecoin force-pushed the nick/mutex branch from edfdcb1 to dc33a43 Compare January 30, 2023 22:56

nick-mobilecoin requested a review from varsha888 January 30, 2023 22:59

nick-mobilecoin mentioned this pull request Jan 30, 2023

Prevent recursive panics from happening #50

Merged

varsha888 approved these changes Jan 30, 2023

View reviewed changes

Base automatically changed from nick/sys-mutex to main January 30, 2023 23:47

nick-mobilecoin merged commit 15e491b into main Jan 30, 2023

nick-mobilecoin deleted the nick/mutex branch January 30, 2023 23:50

nick-mobilecoin mentioned this pull request Jan 31, 2023

Remove unneeded traits on sys types #51

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `mutex.rs` to `mc-sgx-sync` crate #40

Add `mutex.rs` to `mc-sgx-sync` crate #40

nick-mobilecoin commented Jan 17, 2023

nick-mobilecoin commented Jan 17, 2023 •

edited

Loading

codecov-commenter commented Jan 18, 2023 •

edited

Loading

nick-mobilecoin commented Jan 30, 2023

nick-mobilecoin commented Jan 30, 2023 •

edited

Loading

Add mutex.rs to mc-sgx-sync crate #40

Add mutex.rs to mc-sgx-sync crate #40

Conversation

nick-mobilecoin commented Jan 17, 2023

nick-mobilecoin commented Jan 17, 2023 • edited Loading

codecov-commenter commented Jan 18, 2023 • edited Loading

Codecov Report

nick-mobilecoin commented Jan 30, 2023

nick-mobilecoin commented Jan 30, 2023 • edited Loading

Add `mutex.rs` to `mc-sgx-sync` crate #40

Add `mutex.rs` to `mc-sgx-sync` crate #40

nick-mobilecoin commented Jan 17, 2023 •

edited

Loading

codecov-commenter commented Jan 18, 2023 •

edited

Loading

nick-mobilecoin commented Jan 30, 2023 •

edited

Loading